Skip to content

Warn when a private event group's times feed projections - #2233

Merged
moveson merged 2 commits into
masterfrom
oveson/claude/concealed-projections-warnings
Aug 20, 2026
Merged

Warn when a private event group's times feed projections#2233
moveson merged 2 commits into
masterfrom
oveson/claude/concealed-projections-warnings

Conversation

@moveson

@moveson moveson commented Aug 20, 2026

Copy link
Copy Markdown
Collaborator

Summary

Follow-up to #2229/#2231. New events default to use_for_projections = true — correct for real events being set up pre-publication (concealed groups that will go public by race day), but it silently includes new non-public test events with messy or unrealistic data in the projection stream. This PR surfaces the concealed-but-projecting combination at the three moments a user can act on it:

  1. Event form — when the event's group is concealed, an inline warning callout appears under the "Use this event's times for projections" checkbox (a visible callout, not a tooltip).
  2. Setup and setup summary pages — a concealed group with projectable events shows a warning callout naming those events, each linked to its edit form. This catches the case where the group was concealed after the events were created, which the event form alone would miss.
  3. Take Private confirmation — when concealing a group whose events feed projections, the confirm dialog adds: "Even while private, this group's Events will continue to feed pacing plans and projections for their Courses unless you uncheck…" The existing confirm copy was split so the "Are you sure you want to proceed?" question always comes last.

The default itself is deliberately unchanged: defaulting from concealment would silently drop every normal pre-publication event out of projections after it goes public — a worse failure in the common case — and would re-couple the two concepts #2229 just separated.

Testing

  • New system spec covers the setup page (warning shown for concealed + projectable; hidden when visible; hidden when concealed with all flags off), the setup summary page, and the event form (warning shown only when the group is concealed) — 6 scenarios.
  • New helper spec covers the confirm text with and without the addendum.
  • Neighboring suites green: visit event group setup, edit event flow — 18 examples, 0 failures.
  • rubocop and erb_lint clean on touched files.

🤖 Generated with Claude Code

moveson and others added 2 commits August 20, 2026 11:39
New events default to use_for_projections = true, which is right for
real events being set up pre-publication but silently includes test
events with unrealistic times. Surface the combination at the three
moments it matters:

- The event form shows an inline warning under the checkbox when the
  event group is concealed
- The setup and setup summary pages show a warning callout listing the
  projectable events with links to their edit forms
- The Take Private confirmation adds a sentence noting the group's
  events will keep feeding projections unless unchecked

Follow-up to #2229/#2231; see also #2169.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
@moveson
moveson merged commit 55407f5 into master Aug 20, 2026
7 checks passed
@moveson
moveson deleted the oveson/claude/concealed-projections-warnings branch August 20, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant